Preserve "locale" cookie value on redirect to localized URL #715
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Could you add a test ? |
okovpashko
force-pushed
the
fix-locale-cookie-in-redirect
branch
from
4aa57e9
to
518f40b
Compare
|
@iwasherefirst2 done. Please check it out. |
okovpashko
force-pushed
the
fix-locale-cookie-in-redirect
branch
from
518f40b
to
ae105c0
Compare
iwasherefirst2
changed the base branch from
master
to
okovpashko-fix-locale-cookie-in-redirect
iwasherefirst2
changed the base branch from
okovpashko-fix-locale-cookie-in-redirect
to
master
Merged
|
Addressed the issues in PR #920. I retained your original commit as a nod to your contribution—thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the detected locale instead of the first URL path segment to the "locale" cookie during redirect caused by
LocaleCookieRedirectFixes #714